Add optional chaining for owner references #1583
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Bipul Adhikari <[email protected]>
|
/cherrypick release-4.17 |
|
@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.17-compatibility |
|
@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.17-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -11,7 +11,7 @@ export const resolveResourceUntilDeployment = ( | |||
| if (!owner) { | |||
| return null; | |||
| } | |||
| if (owner.kind === DeploymentModel.kind) { | |||
| if (owner?.kind === DeploymentModel.kind) { | |||
There was a problem hiding this comment.
We are checking if (!owner) just before this line, do we need optional chain again ?
|
@bipuladh closing this PR as BZ is already ON_QA. |
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2245068